[mlpack-git] [mlpack/mlpack] Bugfix #350 and some fixes in RStarTreeSplit and XTreeSplit (#556)

[Ryan Curtin]

I agree, `splitHistory` should definitely be part of `XTreeSplit`.  The refactoring looks great to me; my only comment is, I think if the `SplitType` classes hold a pointer to the node they are associated with, this may increase the size of the `RectangleTree` classes.  So I think maybe it would be better to have each of the `SplitType` methods take a pointer to the node, instead of taking the pointer to the node at construction time.  Maybe I have overlooked some reason why that isn't possible---let me know if I've made an error in my thinking.

I'd like to go ahead and merge this for now, so I can release mlpack 2.0.2 with these nice fixes.  Is that okay?  We can finish with the other issues in other PRs as needed.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/556#issuecomment-216252012
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160502/2df71d5c/attachment-0001.html>