[mlpack-git] [mlpack] Neighbor search: Fix error in adjustedScore calculation. (#590)

[Ryan Curtin]

Hi Marcos,

You are right, this is an error.  I think that this problem could, in some bizarre edge cases, cause an invalid prune and cause the results of kNN to be incorrect.  But I did not try to set up a dataset where the issue was actually caused.

This commit will possibly slow things down in some situations, but at least for the corel and covertype datasets, there is no difference in the number of prunes or number of base cases.

It might be interesting to look into whether or not the adjusted score prune on line 234 is even useful for kd-trees.  I wonder if removing it entirely would accelerate kNN when kd-trees (and R/R* trees and ball trees) are used?  Anyway, if you want, feel free to investigate.  I unfortunately don't have time for that.

I know you only changed something like eight characters, but if you'd like to add your name to the list of contributors in `src/mlpack/core.hpp` and `COPYRIGHT.txt`, do feel free.  My requirement for inclusion on that list is "changed at least one character". :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/590#issuecomment-200514937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160323/0e912fbb/attachment.html>