[mlpack-git] [mlpack] Converts CMake commands to lower case (#584)

[ajjl]

CMake commands are sometimes given in upper and lower case.
Previously uppercase commands had been required but now commands are
case-insensitive and lowercase commands are preferred. Conversion to lowercase
commands have been implemented in other open source projects such as ITK vxl
and BRAINSTools, and is the preferred style for KDE. Consistent style
practices help to improve readability and maintainability of code.

This was implemented with the shell script:
NOTE: MUST USE GNU compliant version of sed
    cmake --help-command-list \
    | grep -v "cmake version" \
    | while read c; do
        echo 's/\b'"$(echo $c | tr '[:lower:]' '[:upper:]')"'\(\s*\)(/'"$c"'\1(/g'
      done >convert.sed \
    && git ls-files -z -- bootstrap '*.cmake' '*.cmake.in' '*CMakeLists.txt' \
       | xargs -0 gsed -i -f convert.sed \
    && rm convert.sed

This is a reimplementation of ITK commit
896f6b9220255bed1b3a1409af5257146b54e261
STYLE: Convert CMake-language commands lower case

Fixes #538
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/584

-- Commit Summary --

  * Converts CMake commands to lower case

-- File Changes --

    M CMake/ARMA_FindACML.cmake (38)
    M CMake/ARMA_FindACMLMP.cmake (38)
    M CMake/ARMA_FindARPACK.cmake (36)
    M CMake/ARMA_FindBLAS.cmake (40)
    M CMake/ARMA_FindCBLAS.cmake (42)
    M CMake/ARMA_FindCLAPACK.cmake (44)
    M CMake/ARMA_FindLAPACK.cmake (40)
    M CMake/ARMA_FindMKL.cmake (80)
    M CMake/ARMA_FindOpenBLAS.cmake (38)
    M CMake/FindLibDL.cmake (4)
    M CMake/FindMatlabMex.cmake (84)
    M CMake/TargetDistclean.cmake (8)
    M CMakeLists.txt (4)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/584.patch
https://github.com/mlpack/mlpack/pull/584.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/584
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160321/86dfc144/attachment.html>