[mlpack-git] [mlpack] Reduce (or fix) warnings when compiling with Visual Studio (#554)

[Ryan Curtin]

Sorry, I think my last comment was actually unclear, so you can ignore it...

I don't know if your system is different than AppVeyor.  One easy way to test would be to open a PR, then AppVeyor will automatically build.

Another way to explicitly disable `ARMA_64BIT_WORD` is to define `ARMA_32BIT_WORD`.  I am pretty sure that in general, `ARMA_USE_CXX11` is not enabled when the compiler is Visual Studio though, because VS has incomplete C++11 support.

I don't think that we should enable `ARMA_USE_CXX11` support on Windows because it's been explicitly disabled by the Armadillo maintainer, and enabling it might cause problems for some parts of Armadillo (possibly including parts that are not used in mlpack now but may be used later).  Instead I think maybe we should define either `ARMA_64BIT_WORD` or `ARMA_32BIT_WORD` when on Windows, depending on the architecture.  That would probably accomplish the same result of fixing those warnings.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/554#issuecomment-199366590
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160321/6087ac7e/attachment.html>