[mlpack-git] [mlpack] parallel sgd (#577)
Ryan Curtin
notifications at github.com
Fri Mar 18 12:04:53 EDT 2016
Some quick thoughts on a first pass:
* Please review the style guide and make sure your code follows it: https://github.com/mlpack/mlpack/wiki/DesignGuidelines#style-guidelines
* The `SGD_P` class is a different optimizer than `SGD`, so it should go into its own directory.
* I would suggest the class name of `ParallelSGD` instead, and that it should go in `optimizers/parallel_sgd/`.
* It looks like you have modified some existing tests instead of writing new ones. You should write new tests in a file called `parallel_sgd_test.cpp`.
* Can you please provide some comments on what the Booths Function is?
* Please consider more descriptive commit comments than "change" or similar. http://chris.beams.io/posts/git-commit/
I haven't looked in detail at the code at this point.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/577#issuecomment-198428433
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160318/2756b590/attachment.html>
More information about the mlpack-git
mailing list