[mlpack-git] master: Add comment describing the need for setting PACKAGE and PACKAGE_VERSION. (e93f415)

gitdub at mlpack.org gitdub at mlpack.org
Tue Mar 15 15:55:55 EDT 2016


Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/b3fe52318e33ac10c7bec4abec1d8f15600da06a...e93f41525d6748b0dd993d4f6d041eaf3010d627

>---------------------------------------------------------------

commit e93f41525d6748b0dd993d4f6d041eaf3010d627
Author: Ryan Curtin <ryan at ratml.org>
Date:   Tue Mar 15 12:55:55 2016 -0700

    Add comment describing the need for setting PACKAGE and PACKAGE_VERSION.


>---------------------------------------------------------------

e93f41525d6748b0dd993d4f6d041eaf3010d627
 src/mlpack/core/util/backtrace.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/mlpack/core/util/backtrace.cpp b/src/mlpack/core/util/backtrace.cpp
index 4f89d38..644dfed 100644
--- a/src/mlpack/core/util/backtrace.cpp
+++ b/src/mlpack/core/util/backtrace.cpp
@@ -11,7 +11,6 @@
  * 3-clause BSD license along with mlpack.  If not, see
  * http://www.opensource.org/licenses/BSD-3-Clause for more information.
  */
-
 #include <sstream>
 
 #ifdef HAS_BFD_DL
@@ -19,6 +18,10 @@
   #include <signal.h>
   #include <unistd.h>
   #include <cxxabi.h>
+
+  // Some versions of libbfd require PACKAGE and PACKAGE_VERSION to be set in
+  // order for the include to not fail.  For more information:
+  // https://github.com/mlpack/mlpack/issues/574
   #ifndef PACKAGE
     #define PACKAGE
     #ifndef PACKAGE_VERSION




More information about the mlpack-git mailing list