[mlpack-git] [mlpack] Optimizer transition: Adam, Adadelta (#555)

Marcus Edel notifications at github.com
Fri Mar 11 10:49:18 EST 2016


Okay, maybe we can avoid such situations in the future by assigning the task to the first person who says, I like to work on the issue.

I take a quick look at the pull requests and maybe we can find a way to include both requests.

```adam_impl.hpp``` is basically the same so I like to use that from @vasanthkalingeri, but the test is kind of different, @vasanthkalingeri created a new file instead of updating the old test. So I would use the test from @anamariabs, also @anamariabs added a CMakeLists.txt file to build the optimizer wich is great, so I would also use that. If you both agree, maybe you can update the pull request in that direction?

Since @sshkhrnwbie was the first who said he would like to work on the issue I assign the issue to him, Adadelta is still open. Sorry @awhitesong, but I guess that's the best way to avoid such situations.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/555#issuecomment-195423032
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160311/296345cc/attachment.html>


More information about the mlpack-git mailing list