[mlpack-git] [mlpack] Move mlpack_allknn and mlpack_allkfn (#551)

Ryan Curtin notifications at github.com
Fri Mar 4 20:20:31 EST 2016


This looks good to me, but the only thing is that it doesn't preserve the `mlpack_allknn` and `mlpack_allkfn` programs for reverse compatibility.  Can you look into how that might be done with CMake?  (I'm thinking a symlink on Linux and probably something else is required on Windows.  Not sure.)

Also a couple other notes:

 * want to modify HISTORY.txt and src/mlpack/core.hpp to add your name to the list of contributors? (I'll also add that to about.html on the mlpack website, or you can submit a PR to that repository too)
 * if you can please have more descriptive commit messages, that would be helpful for later... right now your commit messages just say which files you modified, which is information I could get just by using git to print the changed files... :)
 * I didn't think about it, but we should probably make this change for the `mlpack_allkrann` program too (it should change to `mlpack_krann`).  We can do that in another PR or in this one---your call.

Thanks for taking the time to look into this!

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/551#issuecomment-192543252
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160304/a8bb8d5b/attachment-0001.html>


More information about the mlpack-git mailing list