[mlpack-git] [mlpack] Removed trailing underscores in header guards. Resolved issue #533 (#537)

[Ryan Curtin]

@elfring:

I'm not sure what you mean.  The versioning macros can be used by downstream, so they are part of the "public API".

@falit:
> I compiled my changes and ran mlpack_allknn --version and got the following output :
> ```mlpack_allkfn: part of mlpack 2.0.x```

This isn't the correct output; your modifications have caused this to be wrong.  You should compare with an unmodified version of mlpack.

And yes, we will need both version of the versioning macros (with and without underscores), probably accompanied by a note that says the underscored macros will be removed in mlpack 3.0.0.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/537#issuecomment-191875559
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160303/b217e06c/attachment.html>