[mlpack-git] [mlpack] Removed support for MSVC version older than 2015 fro CMake, Issue#508 (#543)

Ryan Curtin notifications at github.com
Thu Mar 3 11:28:34 EST 2016


The error you have made is that the MSVC15 macro is not one that exists.  If you read the CMake documentation you would see that Visual Studio 2015 is represented by the MSVC14 macro:
https://cmake.org/cmake/help/v3.1/variable/MSVC14.html

I cannot accept this patch until it is tested to ensure that it doesn't break anything; so it must be tested on Windows with Visual Studio 2015 to ensure that it still works, and also on at least one earlier version of Visual Studio to ensure that the CMake configuration fails.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/543#issuecomment-191838576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160303/a4790161/attachment.html>


More information about the mlpack-git mailing list