[mlpack-git] [mlpack] Removed trailing underscores in header guards. Resolved issue #533 (#537)

Ryan Curtin notifications at github.com
Wed Mar 2 10:52:54 EST 2016


I agree, the commit message is a bit misleading.  Please consider changing that to what was actually done instead---accuracy in commit messages is really important for later maintenance.

Also, can you please test one thing:

 * compile mlpack with your proposed changes, then run `mlpack_allknn --version`.  The output should be something like `bin/mlpack_allknn: part of mlpack git-48bfcac`.

Lastly, and I forgot about this when I commented on this ticket earlier, there is a bit of complexity involved with changing `__MLPACK_VERSION_MAJOR`, `__MLPACK_VERSION_MINOR`, and `__MLPACK_VERSION_PATCH`, since those may be used by downstream projects.  In accordance with the versioning principles (https://github.com/mlpack/mlpack/blob/master/UPDATING.txt) we should not rename those macros until version 3.0.0.  I think a better idea is to provide both `__MLPACK_VERSION_*` and `MLPACK_VERSION_*`, but note that the macros with the underscores are deprecated and will be removed in future versions (HISTORY.txt should be updated to reflect this change).  Do you think you could change your patch to handle this?

Thanks! :+1: 

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/537#issuecomment-191298398
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160302/09ba9ea4/attachment.html>


More information about the mlpack-git mailing list