[mlpack-git] [mlpack/mlpack] Added the discretize function. Design changes as discussed. (#703)

[Tham]

> +//#define INF 999999.9999
> +//#define EPS 1E-20
> +#include <mlpack/core.hpp>
> +#include "feature_parameters.hpp"
> +namespace mlpack {
> +namespace structured_tree {
> +
> +template <typename MatType = arma::mat, typename CubeType = arma::cube>
> +class StructuredForests
> +{
> + private:
> +  FeatureParameters params;
> +
> + public:
> +
> +  static constexpr double eps = 1e-20;

same as before, if there are no special, could you set it as private data member?

The lesser you let the users access you data directly, the more flexible you can refine your codes in the future without changing the api

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/703/files/0abec2cbb44a0556b129485b485bae8d07986af7#r68396925
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160624/cf73bb28/attachment-0001.html>