[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)
Ryan Curtin
notifications at github.com
Tue Jun 21 15:27:10 EDT 2016
Okay, I have a couple other comments; if you can address these and the ones in the diffs, then if you are happy with the code I will merge it.
* Should we remove `RecursiveHilbertValue`? All of the timing tests I am doing indicate that it takes multiple orders of magnitude longer to construct a tree that way.
* The speed of the Hilbert R tree for searching seems comparable to (sometimes better, sometimes worse) than the R* tree. I think that is about the expected performance.
Sorry for the delay on my end with the review here... this was a lot of code to look through. :)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664#issuecomment-227545526
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160621/7751eabd/attachment.html>
More information about the mlpack-git
mailing list