[mlpack-git] [mlpack/mlpack] Hilbert R tree (#664)

Ryan Curtin notifications at github.com
Tue Jun 21 10:55:50 EDT 2016


>    if (deepCopy)
>    {
>      if (numChildren > 0)
>      {
>        for (size_t i = 0; i < numChildren; i++)
> -      {
>          children[i] = new RectangleTree(*(other.Children()[i]));

I know this is not your code, but I wanted to see if you thought the same thing here... I think this may duplicate the dataset many times, if I do the following:

```
RTree<...> r(dataset); // makes lots of nodes
RTree<...> otherR(r, true /* deep copy */);
```

This will recursively call this constructor with `deepCopy = true`, copying the dataset every single time.  Is my understanding correct there?  If so, I'll open an issue about that separately (no need to fix it here, I think it might take a little thought).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/664/files/f9127cea62d5ce1ad8d5f59931de108a2f7cdd9b#r67884494
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160621/89bc3878/attachment.html>


More information about the mlpack-git mailing list