[mlpack-git] [mlpack/mlpack] edge_boxes: feature extraction updated, tests added (#696)

[stereomatchingkiss]

> +{
> +  arma::vec f(std::max(im.n_rows, im.n_cols));
> +  // transform along columns
> +  for (size_t x = 0; x < im.n_cols; ++x)
> +  {
> +    f.subvec(0, im.n_rows - 1) = im.col(x);
> +    arma::vec d = this->DistanceTransform1D(f, im.n_rows, inf);
> +    im.col(x) = d;
> +  }
> +
> +  // transform along rows
> +  for (size_t y = 0; y < im.n_rows; y++)
> +  {
> +    f.subvec(0, im.n_cols - 1) = im.row(y).t();
> +    arma::vec d = this->DistanceTransform1D(f, im.n_cols, inf);
> +    im.row(y) = d.t();

What kind of type should we declare at the function--DistanceTransform1D?
arma::vec const &f or the view type of row really return?
I know the first one(arma::vec const &f) can work, problem is are you sure this type will the address
but not the copy of row?I used Eigen before, this library is quite picky about this part, not sure about how armadillo handle it.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67197687
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160615/c0f14f00/attachment-0001.html>