[mlpack-git] [mlpack/mlpack] edge_boxes: feature extraction updated, tests added (#696)

[Marcus Edel]

> +  const size_t num_channels = 13;
> +  const size_t rsize = luv.n_rows / shrink;
> +  const size_t csize = luv.n_cols / shrink;
> +  CubeType channels(rsize, csize, num_channels);
> +  
> +  
> +  size_t slice_idx = 0;
> +  
> +  for( slice_idx = 0; slice_idx < luv.n_slices; ++slice_idx)
> +    channels.slice(slice_idx)
> +    = this->bilinearInterpolation(luv.slice(slice_idx), (size_t)rsize, (size_t)csize);
> +
> +  double scale = 0.5;
> +  
> +  while(scale <= 1.0)
> +  {

Another picky comment, I would use a for loop here, that would make the number of iterations clearer.


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67193366
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160615/45b0b67a/attachment.html>