[mlpack-git] [mlpack/mlpack] edge_boxes: feature extraction updated, tests added (#696)

[Marcus Edel]

> +  static constexpr double eps = 1e-20;
> +
> +  std::map<std::string, size_t> options;
> +  
> +  StructuredForests(const std::map<std::string, size_t> inMap);
> +  
> +  MatType LoadData(MatType const &images, MatType const &boundaries,\
> +     MatType const &segmentations);
> +
> +  void PrepareData(MatType const &InputData);
> +
> +  arma::vec GetFeatureDimension();
> +  
> +  arma::vec DistanceTransform1D(arma::vec const &f, const size_t n,\
> +                                 const double inf);
> +  

Another picky comment, please use prefix const, also I know it's a matter of style, but I prefer to use ``type&parameter`` instead of ``type&parameter``. For more details: https://github.com/mlpack/mlpack/pull/523/files/c92dd2fc6561b1cf40efb744dcc9233bc3675c91#r60094845

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/696/files/b38b688edfc4c2ee8bf461240f8384a70575d3a4#r67069686
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160614/264dd56c/attachment-0001.html>