[mlpack-git] [mlpack/mlpack] NeuralEvolution - implemented gene, genome (#686)

[Excalibur]

> +
> +  // Get aFromNeuronId.
> +  unsigned int FromNeuronId() const { return aFromNeuronId; }
> +
> +  // Get aToNeuronId.
> +  unsigned int ToNeuronId() const { return aToNeuronId; }
> +
> +  // Get aInnovationId.
> +  unsigned int InnovationId() const { return aInnovationId; }
> +
> +  // Set aWeight.
> +  void Weight(double weight) { aWeight = weight; }
> +
> +  // Get aWeight.
> +  double Weight() const { return aWeight; }
> +

OK,  got it! I will update my code style later in according with it!

On Thursday, 9 June 2016, Ryan Curtin <notifications at github.com> wrote:

> In src/mlpack/methods/ne/gene.hpp
> <https://github.com/mlpack/mlpack/pull/686#discussion_r66444075>:
>
> > +
> > +  // Get aFromNeuronId.
> > +  unsigned int FromNeuronId() const { return aFromNeuronId; }
> > +
> > +  // Get aToNeuronId.
> > +  unsigned int ToNeuronId() const { return aToNeuronId; }
> > +
> > +  // Get aInnovationId.
> > +  unsigned int InnovationId() const { return aInnovationId; }
> > +
> > +  // Set aWeight.
> > +  void Weight(double weight) { aWeight = weight; }
> > +
> > +  // Get aWeight.
> > +  double Weight() const { return aWeight; }
> > +
>
> I think that the naming convention section of the mlpack style guide was a
> little unclear, it suggested that parameters should have an a in front of
> them but that's not the case, just the examples used there were bad. So I
> would go with weight instead of aWeight. I updated the naming convention
> section, hopefully it is more clear now; let me know if anything still
> needs to be revised. :)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66444075>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AD9tIdBQdgeN2HnGki74ONIL-g9orOKkks5qKBqjgaJpZM4IwJa6>
> .
>


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/686/files/3c8aa62b951f029b3883e9baef1ea556ef5af2d3#r66709885
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160611/4d07015c/attachment-0001.html>