[mlpack-git] [mlpack/mlpack] Optimize load csv 00 (#681)

stereomatchingkiss notifications at github.com
Wed Jun 8 10:03:42 EDT 2016


>Add the following at the end of load_csv.hpp

I think this would cause duplicate symbols, because I did not make the codes inline

>we just need to add load_csv.cpp to the CMakeLists.txt in that directory.

I add load_csv.cpp to the CMakeLists.txt in [this commit](https://github.com/mlpack/mlpack/pull/681/commits/0ceba31326b338c5b55af3c3a353e58006fcf68d), still got the same error. 

I include the header file, and the cpp into the CMakeLists.txt, make sure the include guard do not repeat with other headers(MLPACK_CORE_DATA_LOAD_CSV_HPP). Which  steps I missed?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/681#issuecomment-224598936
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160608/08dd4112/attachment.html>


More information about the mlpack-git mailing list