[mlpack-git] [mlpack/mlpack] fix default output problem and some styles (#680)
Ryan Curtin
notifications at github.com
Tue Jun 7 23:36:48 EDT 2016
> @@ -56,10 +56,10 @@ PARAM_STRING("output_model_file", "File to save trained tree to.", "M", "");
>
> PARAM_STRING("test_file", "File of testing data.", "T", "");
> PARAM_STRING("test_labels_file", "Labels of test data.", "L", "");
> -PARAM_STRING("predictions_file", "File to output label predictions for test "
> - "data into.", "p", "");
> -PARAM_STRING("probabilities_file", "In addition to predicting labels, provide "
> - "prediction probabilities in this file.", "P", "");
> +PARAM_STRING("output_predictions_file", "File to output label predictions for"
> + "test data into.", "p", "");
> +PARAM_STRING("output_probabilities_file", "In addition to predicting labels, "
> + "provide prediction probabilities in this file.", "P", "");
Do you think that changing this parameter name violates our versioning policy for minor release changes? I think I consider this a "public" part of the program, so I don't think we should change it until the next major release (3.0.0, I don't know when that will be), but I could probably be convinced either way.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/680/files/92f3cd11d129367ba1b48d79b3081409ae80707a#r66188303
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160607/9d3cc957/attachment.html>
More information about the mlpack-git
mailing list