[mlpack-git] [mlpack/mlpack] Remove code redundancy in ns_model_impl.hpp (#674)

[stereomatchingkiss]

I think the problem is the api do not allowed the users to specify the type at compile, either

1 : make TreeType as template parameter
2 : use boost variant if you want to avoid code bloat(is this the reason you do not specify TreeTypes as template param?)

Example : 

`NSModel(TreeTypes treeType = TreeTypes::KD_TREE, bool randomBasis = false);`

Make TreeTypes as

`boost::variant<TreeType::KDTree, TreeType::StandardCoverTree, /*and so on*/>`

TreeType::KDTree and other types could be empty class

```
class KDTree
{
};
```

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/674#issuecomment-224048163
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160606/498f7075/attachment.html>