[mlpack-git] [mlpack/mlpack] Refactor for faster assembly of secondHashTable. (#675)

Yannis Mentekidis notifications at github.com
Sun Jun 5 14:37:31 EDT 2016


> I am pretty sure your code had a subtle bug where the user could initialize the LSHSearch object without training, but then the destructor would still try to delete the std::vector<size_t>* object which would cause a crash
You're right I didn't even think about that case.

I like this idea, I think it's quite an improvement over the current implementation. I'm still not clear on how we can first use secondHashSize as the hash size and then compress the empty buckets though. I'll look into your and Pari's code to see that.

I think I can have this working in one or two days... Though I have some final stuff to do with my thesis and I might not be very active till Wednesday, but I'll find time to work on this. So if there isn't a very big hurry, wait for me and release once this is done. I'll do my best to deliver it as soon as possible :)


---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/675#issuecomment-223829360
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160605/79f73b56/attachment.html>


More information about the mlpack-git mailing list