[mlpack-git] [mlpack/mlpack] Resetting stats in NeighborSearch. (#672)

[Ryan Curtin]

I think I have gotten myself confused again.  You are right, there is actually no issue with `treeNeedsReset` since that can only happen for the case of monochromatic search.  So the bug I thought existed, does not exist.

I was not thinking about the overload where the user passes their own query tree; in that case, we have no need to reset the query tree.  I think that we should add documentation ensuring that the user passes a tree with reset bounds, instead of resetting it for them, because (a) that will slow down the `Search()` method and (b) this is already the "advanced" way to call `Search()`, so if users want to build their own special tree that possibly has non-reset bounds for their own reasons, we should allow them to do that.

So in short, I agree with your original statement, that we should add documentation, but I got confused and sidetracked while I was reading through trying to understand. :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/672#issuecomment-223606789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160603/acdedcc7/attachment-0001.html>