[mlpack-git] [mlpack/mlpack] Resetting stats in NeighborSearc. (#672)

[MarcosPividori]

In NeighborSearch, when the method Search(Tree* queryTree, ...) uses the given tree, it is assuming that stats there were intialized to their initial values.
Shouldn't we add a comment about this to the documentation?
I mean, if we do: 
`
KNN knn; 
KNN::Tree queryTree(querySet);
knn.Train(someReferenceSet); 
knn.Search(queryTree,.....); 
knn.Train(someDifferentReferenceSet);
`
The last search will probably give incorrect results, because the queryTree holds old unrelated statistic values for the bounds. I mean, it uses bound values from the first referenceSet to search in the second referenceSet.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/672
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160603/2b5f7ffc/attachment-0001.html>