[mlpack-git] [mlpack/mlpack] Neighbor Search - Incorrect bound. (#642)

[MarcosPividori]

Hi @rcurtin ,
Yes, that makes sense. I think I understand why we didn't see any difference with cover trees. Thank you for the explanation!
I think the slow down won't be really significative. In fact, after adding the member "auxBound" to `NeighborSearchStat`, I realized that there were 2 unused members: "lastDistanceNode" and "bound", which I removed in https://github.com/MarcosPividori/mlpack/commit/ba4c5bbdb4597fb6a5dbc69915961464966ff260 . So, at the end, the size of `NeighborSearchStat` is smaller than before. :)
Definitely, it would be useful to have something like `TraversalTraits` apart from `TreeTraits`, because the way the tree is traversed can make a huge difference when reasoning about the best bound!
I hope I get some time to continue working on this in the near future,
Thanks

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/642#issuecomment-223398612
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160602/1aaa26d5/attachment.html>