[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)
Ryan Curtin
notifications at github.com
Fri Jul 22 11:30:14 EDT 2016
> + }
> +
> + /**
> + * Impute function searches through the input looking for mappedValue and
> + * replaces it with the median of the given dimension. The result is
> + * overwritten to the input matrix.
> + *
> + * @param input Matrix that contains mappedValue.
> + * @param mappedValue Value that the user wants to get rid of.
> + * @param dimension Index of the dimension of the mappedValue.
> + * @param columnMajor State of whether the input matrix is columnMajor or not.
> + */
> + void Impute(arma::Mat<T>& input,
> + const T& mappedValue,
> + const size_t dimension,
> + const bool columnMajor = true)
> I think non static function is better for this case, because we can store the state of imputation in the class if we need to.
I agree in general, I only meant that we could mark this particular function static when it is implemented in classes that do not have any state. I think `CustomImputation` is the only class where these methods could not be marked static.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/e5d591e511ae449eae1523a80346357b93b968d1#r71897859
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160722/8c448109/attachment.html>
More information about the mlpack-git
mailing list