[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Keon Kim]

> +    {
> +      output(target.first, target.second) = mean;
> +    }
> +  }
> +
> +  /**
> +   * Impute function searches through the input looking for mappedValue and
> +   * replaces it with the mean of the given dimension. The result is overwritten
> +   * to the input matrix.
> +   *
> +   * @param input Matrix that contains mappedValue.
> +   * @param mappedValue Value that the user wants to get rid of.
> +   * @param dimension Index of the dimension of the mappedValue.
> +   * @param columnMajor State of whether the input matrix is columnMajor or not.
> +   */
> +  void Impute(arma::Mat<T>& input,

I wanted to reuse the codes of the overloads, but 
Impute(input, input, ...) searches through all values inside the matrix (to produce output), while Impute(input) searches through only with the given dimension.
It would not be very efficient. What do you think?

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/028c217057410e2e75691c32bf062202ce5dca3f#r71871714
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160722/c2bad388/attachment.html>