[mlpack-git] [mlpack/mlpack] Vantage point tree (#708)

[Ryan Curtin]

> +  // same, we can't split them.
> +  if (!split)
> +    return;
> +
> +  // Now that we know the split column, we will recursively split the children
> +  // by calling their constructors (which perform this splitting process).
> +  left = new VantagePointTree(this, splitBegin, splitCol - splitBegin, splitter,
> +      maxLeafSize, true);
> +  right = new VantagePointTree(this, splitCol, splitBegin + splitCount - splitCol,
> +      splitter, maxLeafSize, false);
> +
> +  // Calculate parent distances for those two nodes.
> +  arma::vec center, leftCenter, rightCenter;
> +  Center(center);
> +  left->Center(leftCenter);
> +  right->Center(rightCenter);

Shouldn't the parent distance be identical for both children?  (I think it will just be the distance between this node's vantage point and the left child's vantage point)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/708/files/300882ac96e7a663e3e303ca0c45c14c6fafe1a6#r71807579
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160721/f9a45e03/attachment.html>