[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)
Keon Kim
notifications at github.com
Wed Jul 13 03:29:11 EDT 2016
All the feedbacks are now reflected and patched except for two feedbacks below, because it was unclear how to solve the problem.
- Preserve DatasetMapper object while loading multiple times and add a test for this situation, to ensure that mapping information from a previous load is not destroyed.
(Maybe implement a copy constructor of DatasetMapper class?)
- The problem below.
>Here you are getting a single value out of each column, and each column is held contiguous in memory. So each element you access is probably not in the same cache line, and as a result will probably be slower.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694#issuecomment-232277736
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160713/708c461a/attachment.html>
More information about the mlpack-git
mailing list