[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Ryan Curtin]

> +  {
> +    // Nothing to initialize here.
> +  }
> +
> +
> +  template <typename MapType>
> +  mapped_type MapString(const std::string& string,
> +                        const size_t dimension,
> +                        MapType maps,
> +                        std::vector<Datatype>& types)
> +  {
> +    // If this condition is true, either we have no mapping for the given string
> +    // or we have no mappings for the given dimension at all.  In either case,
> +    // we create a mapping.
> +    const double NaN = std::numeric_limits<double>::quiet_NaN();
> +    if (missingSet.count(string) != 0 &&

Ah, I didn't think of that.  I agree now, putting everything from `missingSet` into `maps` is not the right thing.

I agree, too, Boost spirit seems really cool, I need to play with the code in your PR to see if we can preserve decent compile times.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r70161999
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160708/b9b0edde/attachment.html>