[mlpack-git] [mlpack/mlpack] LSHSearch Parallelization (#700)

[Ryan Curtin]

Ok, great, I am happy to add this.  I made a few changes after the merge.  77d098c removes the `HAS_OPENMP` CMake variable (but not the compiler definition), since it isn't used anywhere.  Let me know if that causes any problems; maybe I misunderstood where you are using it.  (Note that the line `SET(HAS_OPENMP 1)` sets the CMake variable, but `add_definitions(-DHAS_OPENMP)` makes `HAS_OPENMP` available as a macro in the code.)

ca1e3ec and aaefadd are minor style fixes, but the last one, 44c7c35, concerns me a bit; I changed the line `avgIndicesReturned = avgIndicesReturned + refIndices.n_elem` to `avgIndicesReturned += refIndices.n_elem`.  It worked on my system, and it appears that it worked on AppVeyor, but maybe there is something I overlooked, so let me know if there is.  I guess we will find out soon enough if I broke anything like this!

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/700#issuecomment-231465547
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160708/9ae81d1a/attachment-0001.html>