[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Keon Kim]

> +
> +  //! Get the mapper
> +  const MapperType& Mapper() const { return mapper; }
> +
> +  //! Modify the given mapper (be careful!)
> +  MapperType& Mapper() { return mapper; }
> +
> + private:
> +  // StrategyType
> +  StrategyType strategy;
> +
> +  // DatasetMapperType<MapPolicy>
> +  MapperType mapper;
> +
> +  // save transpose as a member variable since it is rarely changed.
> +  bool transpose;

@rcurtin but wouldn't that be confusing to use?
for example, Load() transposes matrix while loading, and if the user wants to apply Imputation after that, he or she needs to pass one more parameter at the end.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r70025695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160707/bb57499a/attachment.html>