[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Ryan Curtin]

> @@ -446,16 +409,16 @@ bool Load(const std::string& filename,
>      if (transpose)
>      {
>        matrix.set_size(cols, rows);
> -      info = DatasetInfo(cols);
> +      info = DatasetMapper<PolicyType>(info.Policy(), cols);

I think it's possible the problem I am thinking of existed in earlier versions of mlpack, but what happens if I do this:

```
arma::mat trainingSet, testSet;
DatasetInfo d;
data::Load("training_set.csv", trainingSet, d);
data::Load("test_set.csv", testSet, d);
```

Ideally the mappings from the first load should be preserved and used for the second load, but the lines here make me think that is not what is happening.  I think probably we should add a test for this situation, to ensure that mapping information from a previous load is not destroyed.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r69907772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160707/3fce59a1/attachment.html>