[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Marcus Edel]

> +using namespace std;
> +using namespace data;
> +
> +int main(int argc, char** argv)
> +{
> +  // Parse command line options.
> +  CLI::ParseCommandLine(argc, argv);
> +
> +  const string inputFile = CLI::GetParam<string>("input_file");
> +  const string outputFile = CLI::GetParam<string>("output_file");
> +  const string missingValue = CLI::GetParam<string>("missing_value");
> +  const double customValue = CLI::GetParam<double>("custom_value");
> +  const size_t dimension = (size_t) CLI::GetParam<int>("dimension");
> +  string strategy = CLI::GetParam<string>("strategy");
> +
> +  // missing value should be specified

First picky comment. Comments should be complete sentences. Take a look at: https://github.com/mlpack/mlpack/wiki/DesignGuidelines#comments

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/a8818316a04506530e2269a2e0a32ba2f6a1c83b#r69799626
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160706/1c6ac7a7/attachment.html>