[mlpack-git] [mlpack/mlpack] Refactor PCA class: able to use different decomposition techniques (exact, randomized, QUIC SVD). (#716)

[Tham]

> @@ -33,10 +35,10 @@ PCA<DecompositionPolicy>::PCA(const bool scaleData,
>   * @param coeff - PCA Loadings/Coeffs/EigenVectors
>   */
>  template<typename DecompositionPolicy>
> -void PCA<DecompositionPolicy>::Apply(const arma::mat& data,
> -                arma::mat& transformedData,
> -                arma::vec& eigVal,
> -                arma::mat& coeff)
> +void PCAType<DecompositionPolicy>::Apply(const arma::mat& data,
> +                                         arma::mat& transformedData,
> +                                         arma::vec& eigVal,
> +                                         arma::mat& coeff)

This parameter should call "eigvec" or "coeff", they are different in pca.hpp and pca_impl.hpp

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/716/files/1c0192f381196e115cc65de5c567a2c1732de52f..1127e61b078faff9baefeeea5b9f75c925f8aed1#r69672305
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160705/510e8e6a/attachment.html>