[mlpack-git] [mlpack/mlpack] Default to DEBUG=OFF and PROFILE=OFF. (#662)
Ryan Curtin
notifications at github.com
Tue Jul 5 14:15:23 EDT 2016
Ok, it seems like everyone thinks using default DEBUG=OFF and PROFILE=OFF is a good idea, so I went ahead and merged commit 3fe0b72 to merge this PR (I did it manually because there is weirdness in this PR and I did not want to try to merge it and break everything...).
@SterlingPeet: thanks for the detailed response. I enjoyed the article you linked to. I think maybe at some point it may be worth changing to the model you suggested, but I am not sure that is a huge deal at the moment (maybe as the project grows that will be more necessary). As it stands now, we do use feature branches, which only get merged when the code is tested and ready. So I guess realistically master only contains code-that-will-be-released-but-maybe-isn't-quite-yet. Anyway, I'll think about it, but it would be some amount of effort to change, so unless someone else wants to take the lead, I'm fine leaving it how it is now (until there is a later problem, perhaps).
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/662#issuecomment-230558362
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160705/059e41b8/attachment.html>
More information about the mlpack-git
mailing list