[mlpack-git] [mlpack/mlpack] Optimize load csv 00 (#681)

Tham notifications at github.com
Mon Jul 4 23:33:09 EDT 2016


>If we can find some way to only include boost::spirit inside of the implementation of LoadCSV,

Up until last night I think this is possible if I provide most of the overload of primitive type users would use(int, float, double,size_t and so on), but now I do not think so, because #694 do some change on DatasetMapper, now you can customize the mapping behavior of it(one more template parameters) , there are too many combinations in this case.

I guess we should try another solution if spirit would slow down the times so much. [This project](https://github.com/ben-strasser/fast-cpp-csv-parser) looks promise, I would test performance first, if it is good, then I will study the codes and adapt it to fit the need of mlpack.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/681#issuecomment-230381118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160704/f7e6a7b4/attachment.html>


More information about the mlpack-git mailing list