[mlpack-git] [mlpack/mlpack] DatasetMapper & Imputer (#694)

[Tham]

>  
> -      typedef boost::bimap<std::string, size_t>::value_type PairType;
> -      maps[dimension].first.insert(PairType(string, numMappings));
> -      return numMappings++;
> +      typedef boost::bimap<std::string, mapped_type>::value_type PairType;
> +      maps[dimension].first.insert(PairType(string, NaN));

Execute ++numMappings at here maybe is better, because insert may throw exception.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/694/files/bace8b25ba703878a1348782e9e4feb210062a47..896a01819631f3a4a0d7ab3fb08189d02435f1c9#r69430620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160704/d6b01fa9/attachment.html>