[mlpack-git] [mlpack] ANN No copy ctor for FNN (#510)

[Joseph Mariadassou]

I made the following changes:
(a) removed circular reference in optimizer as in
`LinearLayer::LinearLayer: optimizer(*this)`
to
`LinearLayer::LinearLayer: optimizer()'

(b) removed  Law of Demeter violations as in
`t.Optimizer().Reset()` to
`t.ResetOptimizer()`

`t.Optimizer().Update()` to
`t.UpdateOptimizer()`

`t.Optimizer().Optimize();` to
`t.OPtimize()`


(c) change optimizer from pointer to shared pointer (TODO: make Optimizer a
member variable)

(d) Implemented copy ctor on top of all this.

(e) Added a few unit tests for copy ctor

(d) All the unit tests except for a couple unrelated to ANN ran to success

The result is in https://github.com/theSundayProgrammer/mlpack





My changes are in

On Sat, Jan 30, 2016 at 6:40 AM, stereomatchingkiss <
notifications at github.com> wrote:

> I added move constructor and move assignment on most of the layers in the
> pull request of #451 <https://github.com/mlpack/mlpack/pull/451>.
> I also change the reference of the output layer of FFN to non-reference
> type, it would be very easy to implement move constructor and move
> assignment for the FFN after #451
> <https://github.com/mlpack/mlpack/pull/451> is merged.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mlpack/mlpack/issues/510#issuecomment-176933500>.
>



-- 
Joseph Chakravarti Mariadassou
http://thesundayprogrammer.com


---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/510#issuecomment-177280888
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160130/48a42faa/attachment.html>