[mlpack-git] [mlpack] removing global dependency on cli deleter (#521)

[Joseph Mariadassou]

I meant:

    delete singleton;
    singleton = NULL; // Reset pointer.
    delete singleton;

should not crash even if the last statement is redundant, because the
delete operator checks for NULL anyway.
 In other words, `if(...)` is redundant whether it is
`if(singleton)`
or
`if(singleton==NULL)`

On Fri, Feb 26, 2016 at 1:15 AM, Ryan Curtin <notifications at github.com>
wrote:

> Yeah, it could be just if (singleton) but in the past I think I wrote it
> out for the sake of clarity. Feel free to change it if you like, but I'm
> fine with it either way.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mlpack/mlpack/pull/521#issuecomment-188800269>.
>



-- 
Joseph Chakravarti Mariadassou
http://thesundayprogrammer.com


---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/521#issuecomment-189007851
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160225/c691a5ca/attachment.html>