[mlpack-git] [mlpack] Adding Copy Ctor to ANN (#519)
Joseph Mariadassou
notifications at github.com
Thu Feb 11 15:47:00 EST 2016
The reason for using C++14 is auto detection of return value in unit tests.
I could create a global FFN and use it to 'decltype'
On Fri, Feb 12, 2016 at 5:12 AM, Marcus Edel <notifications at github.com>
wrote:
> Okay, great so, I think we should merge this code first and then head over
> to #516 <https://github.com/mlpack/mlpack/pull/516>. We have to slightly
> modify #516 <https://github.com/mlpack/mlpack/pull/516>, I can do that if
> no one likes.
>
> About c++14 feature, could we postpone the use of them? Because there are
> a lot of c++14 features do not support by vc2013. Although vc2015 out, but
> cuda do not support vc2015 yet.
>
> The test should build using a C++11 compiler because of the
> conditional-compilation directives Joseph used. But I agree, we should
> avoid C++14 features for the moment, we can easily rewrite the test. I can
> do that once the code is merged.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mlpack/mlpack/pull/519#issuecomment-182984919>.
>
--
Joseph Chakravarti Mariadassou
http://thesundayprogrammer.com
---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/519#issuecomment-183054592
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160211/d0462cef/attachment.html>
More information about the mlpack-git
mailing list