[mlpack-git] [mlpack] ANN No copy ctor for FNN (#510)

Ryan Curtin notifications at github.com
Mon Feb 8 11:19:39 EST 2016


Sorry for the slow response, I didn't really have a chance to look into this until today.  If you'd like to open a PR, that might be a good idea.  A couple quick notes:

 * Please take a glance at the style guidelines -- https://github.com/mlpack/mlpack/wiki/StyleGuidelines -- I'm happy to go over it and make changes after a pull, but it saves time if I don't have to :)

 * Take a look at the other serialization bits in mlpack, like here: https://github.com/mlpack/mlpack/blob/master/src/mlpack/methods/logistic_regression/logistic_regression_impl.hpp#L143 -- basically, I've implemented a big shim that lets us write `Serialize()` instead of `serialize()` for the sake of consistency.  Also, you should use `data::CreateNVP()` to create a name-value pair so that things can successfully be saved to XML archives, instead of just `ar & member`.

If you open a PR, we can discuss in more detail and probably get @zoq's opinion, which will be the important opinion here.

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/510#issuecomment-181423746
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160208/70d9fe76/attachment.html>


More information about the mlpack-git mailing list