[mlpack-git] master: Simplify spill single tree traverser to use GetBestChild. (8b20a4b)

gitdub at mlpack.org gitdub at mlpack.org
Sat Aug 20 14:56:07 EDT 2016


Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/3274b05fcc545c3b36f783316fea2e22f79c3d03...1c77230c7d3b9c45fb102cd3c632d9c7248e085e

>---------------------------------------------------------------

commit 8b20a4bcb938f3c959839753bf246ca297bc489f
Author: MarcosPividori <marcos.pividori at gmail.com>
Date:   Fri Aug 19 12:57:57 2016 -0300

    Simplify spill single tree traverser to use GetBestChild.


>---------------------------------------------------------------

8b20a4bcb938f3c959839753bf246ca297bc489f
 .../core/tree/spill_tree/spill_single_tree_traverser_impl.hpp      | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/mlpack/core/tree/spill_tree/spill_single_tree_traverser_impl.hpp b/src/mlpack/core/tree/spill_tree/spill_single_tree_traverser_impl.hpp
index 0d28969..9cff38c 100644
--- a/src/mlpack/core/tree/spill_tree/spill_single_tree_traverser_impl.hpp
+++ b/src/mlpack/core/tree/spill_tree/spill_single_tree_traverser_impl.hpp
@@ -54,11 +54,8 @@ SpillSingleTreeTraverser<RuleType, Defeatist>::Traverse(
     if (Defeatist && referenceNode.Overlap())
     {
       // If referenceNode is a overlapping node we do defeatist search.
-      if (referenceNode.Left()->HalfSpaceContains(
-          rule.QuerySet().col(queryIndex)))
-        Traverse(queryIndex, *referenceNode.Left());
-      else
-        Traverse(queryIndex, *referenceNode.Right());
+      SpillTree& bestChild = rule.GetBestChild(queryIndex, referenceNode);
+      Traverse(queryIndex, bestChild);
       ++numPrunes;
     }
     else




More information about the mlpack-git mailing list