[mlpack-git] [mlpack/mlpack] Universal B tree implementation (#746)

[Ryan Curtin]

> @@ -877,6 +879,37 @@ template<typename MetricType,
>           template<typename BoundMetricType, typename...> class BoundType,
>           template<typename SplitBoundType, typename SplitMatType>
>               class SplitType>
> +size_t BinarySpaceTree<MetricType, StatisticType, MatType, BoundType,
> +    SplitType>::PerformSplit(MatType& data,
> +    const size_t begin, const size_t count,
> +    const typename UBTreeSplit<BoundType<MetricType>, MatType>::SplitInfo& splitInfo)

Ah, can you split each parameter onto its own line here?  That may necessitate putting `MatType& data` on its own line too so it lines up with the other parameters.  I know it is a minor comment but it is for consistency. :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/746/files/2c5eb5780226c30b8fb088ee928487f0970dc802#r75734533
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160822/2ebe3247/attachment.html>