[mlpack-git] [mlpack/mlpack] Search mode 3.0.0 (#768)

[MarcosPividori]

@rcurtin 
This PR remove the reverse compatibility code inside `NeighborSearch` class.
This is intended to be merged for version 3.0.0.
The only difference with the PR https://github.com/mlpack/mlpack/pull/762  is the last commit.
I will rebase on top of master when https://github.com/mlpack/mlpack/pull/762 is merged, so it will be clearer.
Thanks!
Marcos
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/768

-- Commit Summary --

  * Use enum type to define the different search modes (Closes #750).
  * Remove ambiguity in constructors.
  * Add GreedySingleTreeTraverser.
  * Add GetNearestChild() and GetFurthestChild() methods.
  * Add a new method GetBestChild() to SortPolicies.
  * Define a general GreedySingleTreeTraverser.
  * Add support for Greedy Single Tree Search, inside NeighborSearch class.
  * Define SearchMode outside NeighborSearch class, to it can be used by NSModel.
  * Update NSModel to consider different Search Modes.
  * Update knn/kfn methods and tests, to consider NeighborSearchMode.
  * Fix linker error.
  * Add missed epsilon parameter.
  * Add --algorithm command line option.
  * Fix greedy traverser to consider points in non-leaf nodes.
  * Optimize GetNearestChild for Spill Trees.
  * Simplify spill single tree traverser to use GetBestChild.
  * Add GetFurthestChild() and GetNearestChild() for queryNode.
  * Simplify spill dual tree traverser to use GetBestChild.
  * Always consider the splitting hyperplane to estimate the nearest/furthest child.
  * Improve documentation
  * Return index instead of pointers for GetBestChild().
  * Remove SetSearchMode() and add Greedy() flags.
  * Update tests to use the new API.
  * Use NeighborSearchMode enum type in cf.
  * Update NeighborSearch API to use NeighborSearchMode enum type.

-- File Changes --

    M src/mlpack/core/tree/CMakeLists.txt (2)
    M src/mlpack/core/tree/binary_space_tree/binary_space_tree.hpp (30)
    M src/mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp (98)
    M src/mlpack/core/tree/cover_tree/cover_tree.hpp (30)
    M src/mlpack/core/tree/cover_tree/cover_tree_impl.hpp (116)
    A src/mlpack/core/tree/greedy_single_tree_traverser.hpp (52)
    A src/mlpack/core/tree/greedy_single_tree_traverser_impl.hpp (47)
    M src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp (30)
    M src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp (126)
    M src/mlpack/core/tree/spill_tree/spill_dual_tree_traverser_impl.hpp (56)
    M src/mlpack/core/tree/spill_tree/spill_single_tree_traverser_impl.hpp (7)
    M src/mlpack/core/tree/spill_tree/spill_tree.hpp (47)
    M src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp (145)
    M src/mlpack/methods/cf/cf.cpp (2)
    M src/mlpack/methods/neighbor_search/kfn_main.cpp (68)
    M src/mlpack/methods/neighbor_search/knn_main.cpp (72)
    M src/mlpack/methods/neighbor_search/neighbor_search.hpp (76)
    M src/mlpack/methods/neighbor_search/neighbor_search_impl.hpp (330)
    M src/mlpack/methods/neighbor_search/neighbor_search_rules.hpp (19)
    M src/mlpack/methods/neighbor_search/neighbor_search_rules_impl.hpp (16)
    M src/mlpack/methods/neighbor_search/ns_model.hpp (32)
    M src/mlpack/methods/neighbor_search/ns_model_impl.hpp (142)
    M src/mlpack/methods/neighbor_search/sort_policies/furthest_neighbor_sort.hpp (20)
    M src/mlpack/methods/neighbor_search/sort_policies/nearest_neighbor_sort.hpp (21)
    M src/mlpack/tests/akfn_test.cpp (14)
    M src/mlpack/tests/aknn_test.cpp (32)
    M src/mlpack/tests/kfn_test.cpp (22)
    M src/mlpack/tests/knn_test.cpp (40)
    M src/mlpack/tests/rectangle_tree_test.cpp (28)
    M src/mlpack/tests/serialization_test.cpp (10)
    M src/mlpack/tests/vantage_point_tree_test.cpp (8)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/768.patch
https://github.com/mlpack/mlpack/pull/768.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/768
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160820/6791c7db/attachment.html>