[mlpack-git] [mlpack/mlpack] General greedy traverser. (#762)

[Ryan Curtin]

Aside from my single comment on the code, this looks great and I agree it is ready to merge. I think maybe I want to get 3.0.0 done soon since we are creating a lot of ugly reverse compatibility code! :)

One concern I do have is that right now the `BinarySpaceTree::GetNearestChild()` and `BinarySpaceTree::GetFurthestChild()` functions loop over both children and perform two distance calculations. We can optimize this by calculating which half space the point falls into. Should we wait until the refactoring for random projection trees is done until doing that? If so I am happy to merge now, I just want to make sure that happens eventually.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/762#issuecomment-241017179
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160819/e0664b90/attachment.html>