[mlpack-git] master: Use linspace to fill a Col vector. (0757955)

gitdub at mlpack.org gitdub at mlpack.org
Tue Aug 16 16:25:48 EDT 2016


Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/0f4b25acd6aaa14294c044874ba6cc0751712baa...0a19d07bd39e6223991976474bc79671ba8aa0f0

>---------------------------------------------------------------

commit 075795541bf05a687f18d55083f58e80d48fa79a
Author: MarcosPividori <marcos.pividori at gmail.com>
Date:   Tue Aug 16 17:25:48 2016 -0300

    Use linspace to fill a Col vector.


>---------------------------------------------------------------

075795541bf05a687f18d55083f58e80d48fa79a
 src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp b/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp
index 6b19f06..c677ef2 100644
--- a/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp
+++ b/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp
@@ -36,9 +36,11 @@ SpillTree(
     dataset(&data),
     localDataset(false)
 {
-  arma::Col<size_t> points(dataset->n_cols);
-  for (size_t i = 0; i < points.n_elem; i++)
-    points[i] = i;
+  arma::Col<size_t> points;
+  if (dataset->n_cols > 0)
+    // Fill points with all possible indexes: 0 .. (dataset->n_cols - 1).
+    points = arma::linspace<arma::Col<size_t>>(0, dataset->n_cols - 1,
+        dataset->n_cols);
 
   // Do the actual splitting of this node.
   SplitNode(points, maxLeafSize, tau, rho);
@@ -71,9 +73,11 @@ SpillTree(
     dataset(new MatType(std::move(data))),
     localDataset(true)
 {
-  arma::Col<size_t> points(dataset->n_cols);
-  for (size_t i = 0; i < points.n_elem; i++)
-    points[i] = i;
+  arma::Col<size_t> points;
+  if (dataset->n_cols > 0)
+    // Fill points with all possible indexes: 0 .. (dataset->n_cols - 1).
+    points = arma::linspace<arma::Col<size_t>>(0, dataset->n_cols - 1,
+        dataset->n_cols);
 
   // Do the actual splitting of this node.
   SplitNode(points, maxLeafSize, tau, rho);




More information about the mlpack-git mailing list