[mlpack-git] master: Always normalise a projection vector. (e81731d)

[gitdub at mlpack.org]

Repository : https://github.com/mlpack/mlpack
On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/0f4b25acd6aaa14294c044874ba6cc0751712baa...0a19d07bd39e6223991976474bc79671ba8aa0f0

>---------------------------------------------------------------

commit e81731d94d36c4231d045114443ef4f95946308c
Author: MarcosPividori <marcos.pividori at gmail.com>
Date:   Thu Aug 11 09:57:23 2016 -0300

    Always normalise a projection vector.


>---------------------------------------------------------------

e81731d94d36c4231d045114443ef4f95946308c
 src/mlpack/core/tree/space_split/projection_vector.hpp | 4 ++--
 src/mlpack/core/tree/space_split/space_split_impl.hpp  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mlpack/core/tree/space_split/projection_vector.hpp b/src/mlpack/core/tree/space_split/projection_vector.hpp
index 4b0b2b9..5ade0f9 100644
--- a/src/mlpack/core/tree/space_split/projection_vector.hpp
+++ b/src/mlpack/core/tree/space_split/projection_vector.hpp
@@ -8,7 +8,7 @@
 #define MLPACK_CORE_TREE_SPILL_TREE_PROJECTION_VECTOR_HPP
 
 #include <mlpack/core.hpp>
-
+#include "../bounds.hpp"
 namespace mlpack {
 namespace tree {
 
@@ -102,7 +102,7 @@ class ProjVector
    * @param vect Vector to be considered.
    */
   ProjVector(const arma::vec& vect) :
-      projVect(vect)
+      projVect(arma::normalise(vect))
   {};
 
   /**
diff --git a/src/mlpack/core/tree/space_split/space_split_impl.hpp b/src/mlpack/core/tree/space_split/space_split_impl.hpp
index 96b4235..94f82d8 100644
--- a/src/mlpack/core/tree/space_split/space_split_impl.hpp
+++ b/src/mlpack/core/tree/space_split/space_split_impl.hpp
@@ -88,7 +88,7 @@ bool SpaceSplit<MetricType, MatType>::GetProjVector(
     return false;
 
   // Calculate the normalized projection vector.
-  projVector = ProjVector(arma::normalise(data.col(snd) - data.col(fst)));
+  projVector = ProjVector(data.col(snd) - data.col(fst));
 
   arma::vec midPoint = (data.col(snd) + data.col(fst)) / 2;