[mlpack-git] [mlpack/mlpack] Spill trees (#747)

[MarcosPividori]

> @@ -209,12 +245,6 @@ int main(int argc, char *argv[])
>      Log::Info << "Loaded kNN model from '" << inputModelFile << "' (trained on "
>          << knn.Dataset().n_rows << "x" << knn.Dataset().n_cols << " dataset)."
>          << endl;
> -
> -    // Adjust singleMode and naive if necessary.
> -    knn.SingleMode() = CLI::HasParam("single_mode");
> -    knn.Naive() = CLI::HasParam("naive");
> -    knn.LeafSize() = size_t(lsInt);
> -    knn.Epsilon() = epsilon;

Also, another comment, I think we should provide a command line option:
```
  --mode (-m) [string]
```
So, we can specify different search modes:  *naive*,  *single_mode*, *dual_mode*, *greedy*

Then, when an input model file is provided, we could check if the option "--mode" was specified. In that case, we update the input model file to the given mode.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75176447
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160817/49ab703b/attachment.html>