[mlpack-git] [mlpack/mlpack] Spill trees (#747)

[MarcosPividori]

> +         typename MatType,
> +         template<typename HyperplaneMetricType> class HyperplaneType,
> +         template<typename SplitBoundT, typename SplitMatT> class SplitType>
> +void SpillSearch<MetricType, MatType, HyperplaneType, SplitType>::
> +Search(const MatType& querySet,
> +       const size_t k,
> +       arma::Mat<size_t>& neighbors,
> +       arma::mat& distances)
> +{
> +  if (Naive() || SingleMode())
> +    neighborSearch.Search(querySet, k, neighbors, distances);
> +  else
> +  {
> +    // For Dual Tree Search on SpillTrees, the queryTree must be built with non
> +    // overlapping (tau = 0).
> +    Tree queryTree(querySet, 0 /* tau */, leafSize, rho);

@rcurtin Ok, I see what you mean. But, in the last commits, I also define different single and dual tree traversers for defeatist search. So, we can't consider the default traversers for defeatist search, as `NeighborSearch` does.
Because of that I think we should continue considering a different class for `SpillSearch`.
So the main difference with `NeighborSearch` class is:
 + It includes the parameters `LeafSize`, `Tau` and `Rho`, which are specific for SpillTrees.
 + It ensures we build the query tree with non overlappin (tau = 0).
 + It ensures we use the `DefeatistSingleTreeTraverser` and `DefeatistDualTreeTraverser`.

If we want to include all of this in the `NeighborSearch` class, I think it can become a bit complex ....
What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75062568
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160816/336815f3/attachment.html>